Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/multiboot: close doxy group #5250

Merged
merged 1 commit into from
Apr 13, 2016
Merged

boards/multiboot: close doxy group #5250

merged 1 commit into from
Apr 13, 2016

Conversation

yogo1212
Copy link
Contributor

@yogo1212 yogo1212 commented Apr 6, 2016

No description provided.

@OlegHahm OlegHahm added this to the Release 2016.04 milestone Apr 6, 2016
@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Apr 6, 2016
@A-Paul
Copy link
Member

A-Paul commented Apr 8, 2016

Hey @yogo1212, thanks for finding this issue and fixing it.

A-Paul
A-Paul reviewed Apr 8, 2016
View reviewed changes
boards/x86-multiboot-common/include/multiboot.h
@@ -235,3 +235,5 @@ typedef struct multiboot_mod_list multiboot_module_t;
#endif

#endif /** ! MULTIBOOT_H_ */

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty line.

@yogo1212
Copy link
Contributor Author

@A-Paul ping :-)
i've allowed myself the brazenness of amending the existing commit because of the low number of changes

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 13, 2016
@haukepetersen
Copy link
Contributor

ACK once the CI is green

@Kijewski
Copy link
Contributor

ACK

@Kijewski Kijewski merged commit 340e3ff into RIOT-OS:master Apr 13, 2016
@miri64 miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
@miri64
Copy link
Member

miri64 commented Apr 19, 2016

Needs backport.

@OlegHahm
Copy link
Member

Not so sure, it's only a doxygen fix.

@miri64
Copy link
Member

miri64 commented Apr 19, 2016

Would prefer to have one.

@miri64 miri64 mentioned this pull request Apr 19, 2016
Merged
@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
@yogo1212 yogo1212 deleted the multiboot_doxy branch April 30, 2016 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@A-Paul A-Paul

Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
6 participants
@yogo1212 @A-Paul @haukepetersen @Kijewski @miri64 @OlegHahm