Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic handler #383

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Add topic handler #383

merged 3 commits into from
Oct 20, 2021

Conversation

xforever1313
Copy link
Member

Resolves part of #335.

When an op of an IRC channel changes topics, we now have an option to optionally forward that to Telegram.

Copy link
Member

@Tjzabel Tjzabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a very sad comment word missing its apostrophe friend, this looks good.

// e.Source.Name is the user who changed the topic.
// e.Params[0] is the channel where the topic changed.
// e.Params[1] is the new topic. We should assume that
// this may or may not appear as its possible to clear a topic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its -> it's, but I'll allow it :(

@Tjzabel Tjzabel merged commit 3ebd878 into RITlug:master Oct 20, 2021
@jwflory jwflory added this to the v2.x.x milestone Nov 22, 2021
@jwflory jwflory added IRC Issues relating to the IRC bridge new change Adds new capabilities or functionality labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRC Issues relating to the IRC bridge new change Adds new capabilities or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants