Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 tests: Add initial value to var declaration #388

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

jwflory
Copy link
Member

@jwflory jwflory commented Nov 21, 2021

Fixes an issue caught by golangci-lint, and causes the CI pipeline to pass successfully again.

Note: Merging this and then rebasing PR #387 will cause all the failing tests to start passing. See the CircleCI failed job logs for more context on why this PR is proposed.

Fixes an issue caught by golangci-lint, and causes the CI pipeline to
pass successfully again.

Signed-off-by: Justin W. Flory (he/him) <git@jwf.io>
@jwflory jwflory added bug Something isn't working quality assurance CI tests, unit tests, integration tests, any kind of testing labels Nov 21, 2021
@jwflory jwflory requested a review from a team November 21, 2021 23:27
Copy link
Member

@xforever1313 xforever1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwflory
Copy link
Member Author

jwflory commented Nov 22, 2021

In it goes! Thanks @xforever1313. Merging. 🌊

@jwflory jwflory merged commit 6e85a8c into main Nov 22, 2021
@jwflory jwflory deleted the fix/ci-lint-error branch November 22, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quality assurance CI tests, unit tests, integration tests, any kind of testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants