Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlbot hub alpha #43

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

rlbot hub alpha #43

wants to merge 63 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2019

for some reason the diff tool says i removes some chuncks. im not really used to using the diff tool so maybe someone can help me out on that

Copy link
Member

@skyborgff skyborgff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A future improvement I would like to see is to let the user know how big the bot is before downloading.
For an alpha version this is not important, but I would like users with limited data to be aware.

rlbot_gui/bot_management/bot_creation.py Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jul 29, 2019

i have resolved the conflict, can someone take an look at it?

@skyborgff
Copy link
Member

I think you are currently undoing Tareharts latest commit changes

@ghost
Copy link
Author

ghost commented Jul 29, 2019

@tarehart would you like to help on this one

@ghost
Copy link
Author

ghost commented Jul 29, 2019

also i find that weired because i copied the code for the merge from the rlbot master repo an hour ago

rlbot_gui/gui.py Outdated Show resolved Hide resolved
i see that continuesly refreshing or changing pages before the eel connection can get set results into detecting the browser is closed
@tarehart
Copy link
Contributor

tarehart commented Aug 8, 2019

It seems like this is still using a design of "one repo per bot" which I'm not a big fan of. I very much like having a pull request process like we do in RLBot/RLBotPack for safety and quality control on the main bot pack. Alt packs are fine, but for the main pack I really want to have multiple bots in the same repo to preserve that pull request model.

As a strat for downloading a subtree (i.e. one bot) from a repo:

  1. Look up the latest hash https://developer.github.com/v3/repos/commits/#get-a-single-commit
  2. List out the tree of the bot pack repo https://data.jsdelivr.com/v1/package/gh/RLBot/RLBotPack@a0572e408f012bfa97fe125bf2e377c02cf0aa02
  3. Grab the specific files you want https://cdn.jsdelivr.net/gh/RLBot/RLBotPack@master/RLBotPack/Beast%20from%20the%20East/beastbot.cfg

This would allow us to keep RLBot/RLBotPack in its current form (except we just add a json file) and selectively download bots from inside it.

Alternatively, we could structure repos as a json file and a bunch of bot zips so we don't have to do any recursive monkey business. However, the zips would make git history pretty useless, and it would be harder to test local clones of the bot pack.

@ghost
Copy link
Author

ghost commented Aug 8, 2019

I have thought about it since you noticed it last time, this is my conclusion.

One bot per repo (or branch, just what the developer wants for his administration) does only download the bot the user wants to and helps with the administration of ensuring there aren't multiple bots with the same name in a repo. If you want you can add a rlbot-tested repo where each branch does get an up to date bot instead of a repo per bot where you can store the current and older versions of the bot in branches. The platform does give that freedom.

the current botpack structure does not suit the usecase(s) for the hub since git does (how far I know) only support downloading a file or a full branch, so by shrinking that branch to only one bot and only copying the botfolder from the temp download folder the amount of downloaded data will be reduced for all users.

For the bots that are using a config file to change the behaviour of the bot I want that to be editable in the main page of the gui. I still, don't know a good approch for this one but its something I am thinking of.

When the hub alpha is online it's the responsibility of the bot maker to add the packaging.json, the maintainer of the stable.json bot list only has to upload that to a git repo or branch and if needed ad a new entry in stable.json . For the bots that currently are in the botpack, are working correctly with the latest rlbot and aren't developed anymore we can make the exception of making the packaging.json our self. The process of getting the developers involve will take some time, that is why i am aiming on an early release with some of the basic features.

I hope this does explain my decision and reasoning behind it. If you have questions left feel free to ask them.

@ghost
Copy link
Author

ghost commented Sep 27, 2019

Got the stuff on one page now

@skyborgff
Copy link
Member

For the bots that are using a config file to change the behaviour of the bot I want that to be editable in the main page of the gui. I still, don't know a good approch for this one but its something I am thinking of.

For this we should probably set a standard first, so implementation gets easier, i think this is a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants