Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user defined settings #1

Closed
christianrauch opened this issue Dec 18, 2018 · 5 comments
Closed

allow user defined settings #1

christianrauch opened this issue Dec 18, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@christianrauch
Copy link

For adjusting the size of the program and dynamic memory, it would be nice if the UXR_ macros (e.g. UXR_PACKED_SAMPLES_SEQUENCE_MAX, ...) could be user-defined.

@OpusK
Copy link
Contributor

OpusK commented Dec 18, 2018

Hi, @christianrauch

Thank you for your good feedback. I am also considering this part.

The UXR_ macro you mentioned belongs to the Micro-XRCE-DDS Client library.
I am wondering whether it would be better to ask eProsima officially to allow these definitions to be redefined by the user, or to modify them separately in ros2arduino.

I think we should make a request to eProsima, and if that is difficult, it would be better to consider the second method.

What do you think?

@OpusK OpusK added enhancement New feature or request in progress labels Dec 18, 2018
@OpusK OpusK self-assigned this Dec 18, 2018
@christianrauch
Copy link
Author

I overlooked that the XRCE implementation actually comes from eProsima. In this case, it would of course make sense to talk to them first.
In the micro-ROS thread on https://discourse.ros.org/t/rmw-microxrcedds-implementation/6727 I was actually asking for their plans to support low-end MCUs like the ATmega328. I haven't heard back from them, but I guess they wouldn't mind to have their XRCE implementation more configurable and running on low-end MCUs.

Do you actually plan to have ros2arduino work on the lower-end range of Arduino boards that use the ATmega328 (Micro, Nano, Mini)?

@OpusK
Copy link
Contributor

OpusK commented Dec 18, 2018

Do you actually plan to have ros2arduino work on the lower-end range of Arduino boards that use the ATmega328 (Micro, Nano, Mini)?

Apart from the possibility, I have the plan. In order to do this, it seems that the order is to change the size of the buffers of the Micro-XRCE-DDS Client library and to check that there are no problems in operation.

And to make it more flexible and easier for the user to change, it would be nice to allow the user to override the buffer size as you mentioned.

@OpusK
Copy link
Contributor

OpusK commented Dec 20, 2018

@christianrauch,

I have raised an issue with eProsima regarding this issue.

Most of the definitions in internal.h are protocol-related and should not be modified.

OpusK pushed a commit that referenced this issue Jan 28, 2019
57c90da Merge pull request #1 from ROBOTIS-GIT/develop
11f9543 Added transport related files for baremetal & extend platform.

git-subtree-dir: src/ros2
git-subtree-split: 57c90da19a90b89ce8d35d977497e97f88d7fc5f
@OpusK
Copy link
Contributor

OpusK commented Feb 25, 2019

This issue will be closed since there were no actions for a while. You can reopen this issue to show this issue to the users whenever. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants