[ros2 dashing] remove now obsolete process to set use_sim_time #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
|
@mikaelarguedas This branch will support to Dashing not Crystal. Thank you for your contribution:) |
routiful
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ROS2 Dashing, gazebo_ros_init sets the
use_sim_timeparameter to true by default. It also sets it for each ROS nodes that will be created by gazebo ros plugins.Removing this command allow to run turtlebot3 simulation with SROS2 more easily as it removes a node with an "unknown" node name.
Note: This change is not backward compatible with ROS 2 Crystal, so if this branch targets both crystal and dashing, this PR should be declined / postponed.
Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com