Skip to content

Conversation

samremes
Copy link
Contributor

@samremes samremes commented Sep 22, 2025

Proposed changes

Removal of __builtin_amdgcn_readfirstlane in make_wave_buffer_resource in commit b7322a5 broke the fused_moe kernel. Adding it back with optional parameter to not change other usages of the function.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

aosewski
aosewski previously approved these changes Sep 29, 2025
@ThomasNing ThomasNing merged commit ef43078 into develop Sep 30, 2025
37 of 42 checks passed
@ThomasNing ThomasNing deleted the samremes/fused_moe_fix branch September 30, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants