Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hip to HIP for cuda install #434

Merged
merged 1 commit into from
Nov 30, 2021
Merged

hip to HIP for cuda install #434

merged 1 commit into from
Nov 30, 2021

Conversation

daineAMD
Copy link
Contributor

No description provided.

Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgmb
Copy link
Contributor

cgmb commented Nov 25, 2021

I was wondering if this change was also needed in hipSOLVER. Turns out the answer is: no. This PR is reverting a change made in #351, and hipSOLVER was forked from hipBLAS well before then.

@daineAMD
Copy link
Contributor Author

I am able to reproduce #433 using the instructions given in the ticket, and indeed this PR appears to resolve the issue.

@daineAMD daineAMD merged commit 5f1f2fe into ROCm:master Nov 30, 2021
@daineAMD daineAMD deleted the hip-hotfix branch November 30, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants