Add rocrand to hip::hiprand interface libraries #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are HIP and rocRAND headers included in the hiprand public headers, so they should be linked publicly. The hiprand exported CMake config needs to searching for both hip and rocrand using find_dependency to ensure the targets are available.
cgmb
requested review from
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
stanleytsang-amd
approved these changes
May 1, 2024
|
The CI is currently configured to use a CUDA image that does not exist. As such, the CUDA builds cannot pass. Everything else succeeded, though, so I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are HIP and rocRAND headers included in the hiprand public headers, so they should be linked publicly. The hiprand exported CMake config needs to searching for both hip and rocrand using find_dependency to ensure the targets are available.
Fixes #113