-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Fragment decompiler improvements #10764
Conversation
- Perspective correction flag multiplies VP output by HPOS.w. NOTE: Not the same as division by w when it comes to NaN/Inf problems!! - Restructure indexed loads a bit to avoid re-initializing registers unnecessarily
|
Fixed now. |
fixes #6304 |
Fixes: #5610. |
Confirmed fixed:
The RSX rendering issues reported in #10494 seemed related too, specifically as it involves lighting, though it didn't change. As I'm finding, this PR is bound to resolve lots of other long-standing rendering issues reported and otherwise - please all continue testing and reporting changes. Amazing stuff @kd-11! |
Can you post before/after for Birds of Steel |
Okay, apparently #8459 had already been resolved. In recent testing the water wasn't rendered properly, though it's fine in the current master so my last test wasn't recent enough - sorry for any confusion. The others reported above were checked against the most current master, commit 72f0637. Regardless, #8459 can probably be closed and I've posted a screenshot from the latest master in that report. |
This effect went unnoticed because if you use a w output of 1.0, there is no difference. Discovered when fuzzing unknown SRC2 bits.
This fixes a lot of games with strange texturing bugs. Add here to close with the ticket:
Fixes #5138
Fixes #6798
Fixes #7721
Fixes #7378
Fixes #6304
Fixes #5610