vm: Avoid unnecessary preallocations #12443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be solved more cleverly by utilizing copy-on-write zero pages. On systems with overcommit support this problem doesn't exist in the first place. |
|
Superseded by #12466 |
|
Just testing. |
|
Untested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's no secret RPCS3 is a bit of a memory hog, with 16GB of RAM while in-game and a few Chrome tabs open (not even including background 3rd party processes) you can run out of RAM and use the system pagefile (extremely slow memory compared to RAM located on disk). Luckily there is a simple change to reduce more than 0.5GB already: by avoiding preallocating the whole VM regions at once, using blocks of 32MB and allocating them as needed instead.