Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: use keyboard consumers to seperate cell and overlay logic #15506

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Apr 25, 2024

Currently it is possible to initialize a basic keyboard handler in the overlay input loop, ignoring cellKb.
This can potentially cause bugs or unexpected behaviour if a game uses cellKb (like having key repeat active by mistake).

  • Adds consumer subscription model to the basic keyboard handler.
  • cellKb and the overlay input loop now each have their own subscription.
  • This allows the overlay input loop to use key repeat by default without influencing cellKb behaviour.
  • Properly ignore basic keyboard input in the osk if the pad handler is set to keyboard and pad input is disabled
  • Added the caps lock and the meta key (windows key) to the basic keyboard handler
  • Added opencv to gitignore for undisclosed reasons

Supersedes #15501
Thanks for finding these issues @cipherxof

@Megamouse Megamouse merged commit fcba193 into RPCS3:master Apr 26, 2024
4 of 6 checks passed
@Megamouse Megamouse deleted the tetssss branch April 27, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant