Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSK event hook callback key code #15624

Merged
merged 3 commits into from
May 26, 2024
Merged

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented May 24, 2024

  • Use raw cell key code in CellOskDialogKeyMessage (🤦 we don't need the Qt code)
  • Clarify cellKbCnvRawCode alphabet conversion (this was a bit confusing to read)
  • Don't use caps lock as shift lock unless we are using the qwertz or azerty layout

maybe fixes #15516

@Dormant-Hero
Copy link

Okay everything from issue 15516 I have numbered. Please note that for my test I am using fedora and UK extended keyboard. THe setting in the game is US as we normally find this works best. If you would like me to change and report results then let me know.

Issues in 15516:
1)Tab (used to switch between /all and /team chat)

2)Arrows (in MGO Arrow Key Up / Down go through a history of sent messages by the player, Up going to older ones and Down to the most recent, including the current one being typed. Left and Right work as intended)

3)Caps Lock works but also acts as Shift while enabled

4)F1 to F12 (used as text macros)

5)` requires the user to press twice, while realhw requires one press

6)' (") same as above

While Caps Lock is disabled:

  1. ; types ; and acts as F2
  2. = types = and acts as F4

While Caps Lock is enabled (acts as Shift too as pointed out before, makes other keys act differently):

  1. Shift + 0 deletes the whole message

  2. 2 types @ and acts as F7

  3. = types + and acts as Tab on each press

  4. E types E and acts as F12

  5. R on each press goes back to other typed messages (it's acting as one of the arrow keys)

  6. A types A and acts as F8

  7. D types D and acts as F11

  8. ; types : and acts as F1

  9. C types C and acts as F10

  10. B types B and acts as F9

  11. , types < and acts as F3

  12. . types > and acts as F5

  13. / types ? and acts as F6

  14. There's also another issue where Caps Lock keeps the last state it received if changed outside of the emulator, e.g:
    You enable Caps Lock, go outside RPCS3, disable Caps Lock and type, you'll still type in uppercase.

Dormant Retard Comments:

  1. Tab works correctly as it is supposed to now. I am very happy.
  2. Up and down arrow keys are working as I would expect.
  3. Caps lock still works as a shift modifier (e.g. on a BR'ISH keyboard hitting 1 would get me !)
  4. Macros work for me
  5. ` works fine for me with just one mighty press
  6. Not sure if ' and " work with just one mighty press
  7. ; acts as it should. Could not test the other one as I do not have it on keyboard or blind retard.
  8. = just types = now so that is good
  9. shift + 0 does not delete the message for me (good thing)
  10. Only the shift modified result happens. No longer acting as F7
  11. Only the shift modified result of + happens to me when caps lock is enabled
  12. E behaving exactly as it should be
    13)R is working how it should
  13. A is working as it should
  14. D is working as it should
  15. ; is just getting me the shift modified result. No macro.
  16. C is working as it should
  17. B is working as it should
  18. , is just getting the shift modified result. No macro.
  19. . is just getting the shift modified result. No macro.
  20. / is just getting the shift modified result. No macro
  21. as discussed with yourself cannot be fixed therefore understood megaboss sensei.

@Dormant-Hero
Copy link

Thanks keyboard sensei. All seems to work fine on my end at the moment.

@Megamouse Megamouse merged commit c0ed56c into RPCS3:master May 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong key behaviour while typing on keyboard
2 participants