Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellVdec: stub unsupported video timebases #4458

Merged
merged 2 commits into from
Jul 21, 2018
Merged

cellVdec: stub unsupported video timebases #4458

merged 2 commits into from
Jul 21, 2018

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Apr 18, 2018

needs testing to be sure it doesnt result in weird cutscene speeds or unwanted artifacts in affected games.
fix #4110

@legend800
Copy link

legend800 commented Apr 18, 2018

RR7 no longer needs BGM disabled in-game to avoid crashes.

Tested PR build with a few configs, but still crashes unless libvdec is manually selected. Some details:

Loadlv2.sprx only and BGM disabled in-game:
F {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} class std::runtime_error thrown: Unknown colorMatrixType (1065353216)
(in file Emu\Cell\Modules\cellVdec.cpp:623)
E {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} Stat: 'sys_ppu_thread_set_priority' failed with 0x80010005 : CELL_ESRCH [x8]
E {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} Stat: 'sys_cond_destroy' failed with 0x80010005 : CELL_ESRCH [x4]

Automatically load req. libraries and BGM enabled in-game:
F {PPU[0x100002b] Thread (bnusCoreDecoderAT3PThread) [0x00399d00]} MEM: Access violation writing location 0x0
F {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} class std::runtime_error thrown: Unknown colorMatrixType (1065353216)
(in file Emu\Cell\Modules\cellVdec.cpp:623)
E {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} Stat: 'sys_ppu_thread_set_priority' failed with 0x80010005 : CELL_ESRCH [x8]
E {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} Stat: 'sys_cond_destroy' failed with 0x80010005 : CELL_ESRCH [x4]

Automatically load req. libraries and BGM disabled in-game:
S {rsx::thread} RSX: New program compiled successfully
F {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} class std::runtime_error thrown: Unknown colorMatrixType (1065353216)
(in file Emu\Cell\Modules\cellVdec.cpp:623)
E {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} Stat: 'sys_ppu_thread_set_priority' failed with 0x80010005 : CELL_ESRCH [x7]
E {PPU[0x1000000] Thread (main_thread) [0x002d42c8]} Stat: 'sys_cond_destroy' failed with 0x80010005 : CELL_ESRCH [x4]

RPCS3.log-auto libs.gz
RPCS3.log-libv2 only.gz

EDIT:
Checked mainline and found that 'BGM=Off' wasn't needed there either anymore. Guess that was something else that fixed that.

@JackTerok
Copy link

With this Angry Birds Star Wars Time base error is fixed. Now goes ingame.

@AniLeo
Copy link
Member

AniLeo commented May 6, 2018

This should probably be logged as an error, otherwise it may get forgotten

@PlayerWind
Copy link

Game:Devil May Cry 4

Log: http://ge.tt/4HZCKip2

Some Missing HLE

@AniLeo
Copy link
Member

AniLeo commented May 7, 2018

Can't open what you uploaded, why did you even upload 16MB of uncompressed text? It's waste of bandwidth, log is automatically compressed for a reason.

Make sure there's actual cellVDec stuff in there, otherwise it's not relevant to this issue.

@Nekotekina
Copy link
Member

Nekotekina commented May 15, 2018

It's wrong
Details were discussed in Discord.

@Nekotekina Nekotekina merged commit 12b8908 into RPCS3:master Jul 21, 2018
@elad335 elad335 deleted the hack_cellvdec branch July 21, 2018 11:40
@Hasster1
Copy link
Contributor

Oh my god... I thought no one is looking for the old PR's. Good.

@elad335 elad335 changed the title cellvdec: stub unsupported video timebases cellVdec: stub unsupported video timebases Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLE: cellVdec - Unsupported time_base.num
7 participants