Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Restructure ZCULL query triggers #7582

Merged
merged 2 commits into from
Feb 26, 2020
Merged

rsx: Restructure ZCULL query triggers #7582

merged 2 commits into from
Feb 26, 2020

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Feb 24, 2020 •
edited
Loading

Overview

  • Both ZCULL stats and ZPASS stats require hardware queries, but ZCULL stats should not contribute to ZPASS stats and vice versa!
  • Disables hardware queries for ZCULL stats by themselves, we cannot generate them correctly anyway and no game so far has been found to actually use them. Should lessen the load on the backend for games that do not actually require it.

Notes

  • Fixes sun shining indoors in Dark Souls
  • Also significantly lowers the number of issued hw queries and could theoretically improve performance in some applications.

@Megamouse Megamouse added the RSX label Feb 24, 2020
@RainbowCookie32
Copy link
Contributor

Also fixes the sun in Alien Isolation

Before:
image

This PR:
image

@kd-11 kd-11 changed the title [TESTERS NEEDED] rsx: Restructure ZCULL query triggers rsx: Restructure ZCULL query triggers Feb 25, 2020
@kd-11
rsx: Restructure ZCULL query triggers
1be9d07 
- Both ZCULL stats and ZPASS stats require hardware queries, but
  ZCULL stats should not contribute to ZPASS stats and vice versa!

- Disables hardware queries for ZCULL stats by themselves, we cannot
  generate them correctly anyway and no game so far has been found to
  actually use them. Should lessen the load on the backend for games
  that do not actually require it.
@kd-11
rsx: Fix typo. Noted by github user @gamerforEA
3d0bc9f
@kd-11 kd-11 merged commit 569e1c2 into RPCS3:master Feb 26, 2020
@kd-11 kd-11 mentioned this pull request Feb 28, 2020
Merged
@solarmystic solarmystic mentioned this pull request Feb 28, 2020
Open
@MsDarkLow MsDarkLow mentioned this pull request Feb 28, 2020
Closed
@jeremybris jeremybris mentioned this pull request Aug 18, 2020
Merged
4 tasks
@kd-11 kd-11 deleted the zcull branch August 23, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RSX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kd-11 @RainbowCookie32 @Megamouse