Add more preferences for controlling the lumens overlay and environmental lighting #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some very rare circumstances (probably just campaigns built during development), it is possible for a serialized `LightSource.lightList` to be `null`. We now handle that case as equivalent to the light source having no lights.
The lumens overlay already had a configurable opacity, but now also has a configured thickness for the borders. There is also a new toggle to control whether the lumens overlay is shown by default, and a corresponding one to control whether the environmental lighting is shwon by default.
thelsing
approved these changes
Mar 4, 2023
Phergus
approved these changes
Mar 4, 2023
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Improves #3817
Description of the Change
Three new preferences are added to improve the experience with the new lumens overlay and environmental lighting:
There is also a minor tweak to handle a case overlooked in the first PR for #3817: a serialized
LightSourcecan rarely be missing alightList, resulting in a NPE when loading a campaign. This case is now handled inLightSource#readResolve().Possible Drawbacks
The ever-increasing set of preferences is now even larger.
Documentation Notes
The thickness of the lumens overlay border can be controlled via the Application tab of the Preferences dialog. Setting it to zero will remove the border entirely.
When MapTool starts, the lumens overlay and/or environmental lighting can be shown. These are also controlled via the Application tab of the Preferences dialog.
Release Notes
This change is