chore(package): Add eslint-plugin-ava and lint command, and specify files #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is super cool, but some rules are kinda weird. https://github.com/avajs/eslint-plugin-ava Why use |
|
It's just much less to type. When you get up to 100s of tests it's a lot of time saved. And it's good to be consistent with others using AVA, especially since the authors have defined these best practices in an eslint plugin. |
|
TBH though, more important to me is to get #7 merged. This one would be nice if we can come to a consensus (maybe disable some of the rules?) but it's not too critical. |
|
I agree. Would be cool if this PR enables a sensible set of rules. Right now, I think it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.