Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TwitterBridge] Append username of retweeter to author #1016

Merged
merged 5 commits into from
Feb 4, 2019
Merged

[TwitterBridge] Append username of retweeter to author #1016

merged 5 commits into from
Feb 4, 2019

Conversation

triatic
Copy link
Contributor

@triatic triatic commented Jan 22, 2019

Append username of retweeter to author. Useful when viewing all unread tweets in an RSS reader which are not sorted within username folders.

@triatic
Append username of retweeter to author.
1b4ed77 
Append username of retweeter to author. Useful when viewing all unread tweets in an RSS reader which are not sorted within username folders.
@triatic
Decode username
3ed1a75
@triatic triatic changed the title Append username of retweeter to author. Append username of retweeter to author Jan 22, 2019
@triatic triatic changed the title Append username of retweeter to author [TwitterBridge] Append username of retweeter to author Jan 22, 2019
logmanoriginal
logmanoriginal reviewed Feb 3, 2019
View reviewed changes
Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This is generally working well for me. Find below a small improvement to the condition.

bridges/TwitterBridge.php Outdated Show resolved Hide resolved
@logmanoriginal logmanoriginal merged commit 25593d9 into RSS-Bridge:master Feb 4, 2019
@triatic triatic deleted the patch-2 branch March 15, 2019 01:02
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
@triatic @logmanoriginal
[TwitterBridge] Append username of retweeter to author (RSS-Bridge#1016)
3ef2a8a 
Append username of retweeter to author. Useful when viewing all unread tweets in an RSS reader which are not sorted within username folders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logmanoriginal logmanoriginal logmanoriginal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@triatic @logmanoriginal