Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CachetBridge] Add CachetBridge #1034

Merged
merged 7 commits into from
Feb 11, 2019

Conversation

klimplant
Copy link
Contributor

Cachet is going to drop it's own RSS feed as mentioned in #1028. This Bridge takes the official Cachet API and converts it.

Fixing issue that only the oldest 20 entries were shown.

_Background:_

_Cachet has a, lets call it odd, system of pagination. On the first page you see the incidents first created, so they are not what you want to see. But on the last page you can have 1 or 20 of the newest incidents. So you have to take the incidents from the last page (call it Pmax) and combine them with the incidents from  Pmax - 1._
@Perflyst
Copy link

Works very well, I already use this in production.

Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I found a small typo and added a suggestion regarding the function isValidJson below.

bridges/CachetBridge.php Outdated Show resolved Hide resolved
bridges/CachetBridge.php Outdated Show resolved Hide resolved
@logmanoriginal logmanoriginal merged commit 4c58768 into RSS-Bridge:master Feb 11, 2019
@logmanoriginal
Copy link
Contributor

Merged. Thanks again!

@klimplant klimplant deleted the CachetBridge branch February 11, 2019 20:12
@klimplant klimplant mentioned this pull request Feb 11, 2019
10 tasks
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* Fix issue with CachetAPI Pagination

Fixing issue that only the oldest 20 entries were shown.

_Background:_

_Cachet has a, lets call it odd, system of pagination. On the first page you see the incidents first created, so they are not what you want to see. But on the last page you can have 1 or 20 of the newest incidents. So you have to take the incidents from the last page (call it Pmax) and combine them with the incidents from  Pmax - 1._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants