Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIMARBridge]: Add new bridge #1055

Merged
merged 4 commits into from
Apr 16, 2019
Merged

Conversation

somini
Copy link
Contributor

@somini somini commented Mar 4, 2019

Another hyper-specific bridge, just like #1049

@somini somini changed the title [New Bridge]: SIMAR [SIMARBridge]: Add new bridge Mar 4, 2019
Copy link
Member

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks good to me.
Find below a few points for consideration.

bridges/SIMARBridge.php Outdated Show resolved Hide resolved
bridges/SIMARBridge.php Outdated Show resolved Hide resolved
@somini
Copy link
Contributor Author

somini commented Apr 13, 2019

Rebased this to the latest master branch.

@teromene teromene merged commit 8f5151b into RSS-Bridge:master Apr 16, 2019
@teromene
Copy link
Member

Thanks for the PR ! Merged !

@somini somini deleted the new-bridge/simar branch April 16, 2019 16:39
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants