-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BrutBridge] New bridge #1159
Merged
Merged
[BrutBridge] New bridge #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logmanoriginal
requested changes
Jun 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting bridge, thanks for the PR 👍
Find below a few comments for consideration. Please also take a look at the complaints from Travis.
Use getURI() to create URLs as suggested by @logmanoriginal in code review. #1159 (comment)
Replaces twitter image regex with code suggested by @logmanoriginal in code review. #1159 (comment)
Move location of item limit check and use code suggested by @logmanoriginal in code review. #1159 (comment)
logmanoriginal
approved these changes
Jun 8, 2019
Remove whitespace from end of line 81
Looks good to me. Thanks again for the PR 👍 |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
@VerifiedJoseph The bridge is currently broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bridge for Brut. Returns the 5 newest videos by category and edition. closes #1092