[Multiple] Fix all exampleValues and required variables #2296
Conversation
|
Ouh oh... i didnt check that lists cant have a required... crappo.. I will need to check what this changes. |
|
slow clap From what I can tell there's no real loss of information here. Great job, LGTM. |
Co-authored-by: Yaman Qalieh <ybq987@gmail.com>
Co-authored-by: Yaman Qalieh <ybq987@gmail.com>
|
LGTM, just a couple changes :) |
| ) | ||
| ), | ||
| 'User Wantlist' => array( | ||
| 'username_wantlist' => array( | ||
| 'name' => 'Username', | ||
| 'type' => 'text', | ||
| 'required' => true, | ||
| 'exampleValue' => 'TheBlindMaster', | ||
| ) | ||
| ), | ||
| 'User Folder' => array( |
There was a problem hiding this comment.
See https://www.discogs.com/developers/#page:user-collection,header:user-collection-collection-folder
It looks like only folderid = 0 is accessible to us at this time. Since this PR is focused only on the default/example values, the best settings for this context are:
'User Folder' => array(
'username_folder' => array(
'name' => 'Username',
'type' => 'text',
'required' => true,
'exampleValue' => 'TheBlindMaster'
),
'folderid' => array(
'name' => 'Folder ID',
'type' => 'number',
'required' => true,
'defaultValue' => 0
)
)
| @@ -9,15 +9,17 @@ class HDWallpapersBridge extends BridgeAbstract { | |||
| const PARAMETERS = array( array( | |||
| 'c' => array( | |||
| 'name' => 'category', | |||
| 'required' => true, | |||
There was a problem hiding this comment.
This bridge doesn't require a category, but I think latest_wallpapers is equivalent to blank category. Either way, it's a small issue since the bridge only returns broken links.
| @@ -9,6 +9,7 @@ class IKWYDBridge extends BridgeAbstract { | |||
| array( | |||
| 'ip' => array( | |||
| 'name' => 'IP Address', | |||
| 'exampleValue' => '8.8.8.8', | |||
There was a problem hiding this comment.
I saw that your tests showed that 8.8.8.8 returned a list of 2. I get an empty feed and I'm not sure why.
This IP returns a non-empty feed and the ip seems to belong to reliablehosting.com (a non-personal company)
We can also choose other examples from here: https://iknowwhatyoudownload.com/en/peers/?id=3f69ea4d38f96aa93746a68f5af33dd9d51c7c30343f33f71677a2c7157a79726547f5dabbe7145996dc298fc91a02a9&country=US
| 'exampleValue' => '8.8.8.8', | |
| 'exampleValue' => '216.131.86.165', |
|
Wow this is really nice piece of work. Make it much easier for users to test a bridge. Thank you. |
|
@em92 I would love to have this merged as it is. The leftover comments are more about flavor and can be done in their own PRs if someone wants to. They don't effect the validity of this PR and merging this will help a lot with the progress of the bridge tester. |
|
Can this be merged please? Excellent work by @Bockiii |
|
The problem is: the longer we wait, the more merge conflicts could come up. |
|
Awesome, thank you @Bockiii for your work! |
|
Please merge this @em92 Will make it easier to continue the work of automatic testing of bridges. |
|
Alright, the only linting error is actually solved by #2521 so it doesnt concern me. I will add another small PR to re-add the examplevalue on the giphy bridge (didnt want to deal with the merge conflict because giphy was updated in the mean time.. this is easier. |
Hi,
I went through the bridges and added/fixed all exampleValues and required statements for all bridges.
This PR is probably not done right now and is WIP after I'm done testing.