Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can go back to the form #4087

Closed
wants to merge 4 commits into from
Closed

Conversation

boyska
Copy link

@boyska boyska commented Apr 20, 2024

I tried to solve #4017. The easiest way I could find was to just add a new format.

That's the UX:

As for the implementation, i wanted to avoid repeating the code to generate the form, so I extended BridgeCard a fair bit, so that it now allows parameters to be set from the request. This required changing the prototype of many methods!

@boyska boyska marked this pull request as ready for review April 20, 2024 22:16
@dvikan
Copy link
Contributor

dvikan commented Jun 18, 2024

thanks for the pr!

in my humble opinion, this is too much code, too many changes and too much increased complexity for this feature.

@dvikan dvikan closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants