Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FacebookBridge] Ensure item is fully decoded #925

Merged
merged 2 commits into from
Nov 16, 2018
Merged

[FacebookBridge] Ensure item is fully decoded #925

merged 2 commits into from
Nov 16, 2018

Conversation

triatic
Copy link
Contributor

@triatic triatic commented Nov 15, 2018

Ensure item is fully decoded. I've witnessed a few incidences of " in the RSS feed.

Ensure item is fully decoded. I've witnessed a few incidences of " in the RSS feed.
Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Find below a comment regarding $date. Can you also share a sample query for testing?

bridges/FacebookBridge.php Outdated Show resolved Hide resolved
@triatic
Copy link
Contributor Author

triatic commented Nov 15, 2018

Example post where " appears in title: https://www.facebook.com/bbcnews/videos/1579028138909795/

@logmanoriginal logmanoriginal merged commit 599d438 into RSS-Bridge:master Nov 16, 2018
@logmanoriginal
Copy link
Contributor

Merged. Thanks for fixing it! 👍

@triatic triatic deleted the patch-8 branch November 21, 2018 16:36
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants