Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MozillaSecurity] New Bridge #946

Merged
merged 6 commits into from
Nov 30, 2018
Merged

[MozillaSecurity] New Bridge #946

merged 6 commits into from
Nov 30, 2018

Conversation

Nono-m0le
Copy link
Contributor

Kudo to @teromene & @ArthurHoaro on this one !

Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

Please take a look at the indentation of the code inside the class. Each line has two unnecessary indents. Find below a suggestion to improve the replacement of relative URIs.

bridges/MozillaSecurity.php Show resolved Hide resolved
bridges/MozillaSecurity.php Outdated Show resolved Hide resolved
logmanoriginal and others added 2 commits November 30, 2018 12:31
Co-Authored-By: Nono-m0le <nono@m0le.net>
Co-Authored-By: Nono-m0le <nono@m0le.net>
@Nono-m0le
Copy link
Contributor Author

it gives me links with two "//" in content links but that's not a big deal I guess.

@teromene teromene merged commit 2184f52 into RSS-Bridge:master Nov 30, 2018
@Nono-m0le Nono-m0le deleted the patch-1 branch November 30, 2018 18:25
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* [MozillaSecurity] New Bridge

Kudo to @teromene & @ArthurHoaro on this one !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants