Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MozillaSecurity] New Bridge #946

Merged
merged 6 commits into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@Nono-m0le
Copy link
Contributor

commented Nov 28, 2018

Kudo to @teromene & @ArthurHoaro on this one !

Nono-m0le added some commits Nov 28, 2018

@LogMANOriginal
Copy link
Member

left a comment

Thanks for the PR 👍

Please take a look at the indentation of the code inside the class. Each line has two unnecessary indents. Find below a suggestion to improve the replacement of relative URIs.

Show resolved Hide resolved bridges/MozillaSecurity.php
Show resolved Hide resolved bridges/MozillaSecurity.php Outdated

LogMANOriginal and others added some commits Nov 30, 2018

Update bridges/MozillaSecurity.php
Co-Authored-By: Nono-m0le <nono@m0le.net>
Update bridges/MozillaSecurity.php
Co-Authored-By: Nono-m0le <nono@m0le.net>
@Nono-m0le

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2018

it gives me links with two "//" in content links but that's not a big deal I guess.

Nono-m0le added some commits Nov 30, 2018

@teromene teromene merged commit 2184f52 into RSS-Bridge:master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Nono-m0le Nono-m0le deleted the Nono-m0le:patch-1 branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.