Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrelloBridge] Add new bridge #971

Merged
merged 4 commits into from
Dec 26, 2018
Merged

Conversation

Roliga
Copy link
Contributor

@Roliga Roliga commented Dec 19, 2018

Adds a new bridge for activity on boards and cards on the trello.com task management site.

Adds a new bridge for activity on boards and cards on the trello.com
task management site.
@Roliga
Copy link
Contributor Author

Roliga commented Dec 19, 2018

Hmm, private consts aren't allowed apparently. I'm not sure what the best way to include a large array of constants in a bridge is. Regular public const in the class? Make it a local (static?) variable in a function? Some tips would be appreciated!

@logmanoriginal
Copy link
Contributor

Thanks for the PR!

Hmm, private consts aren't allowed apparently.

Yes, we still need to be compatible to PHP 5.6 which doesn't support private const. They were added in PHP 7.1: http://php.net/manual/en/language.oop5.constants.php

I'm not sure what the best way to include a large array of constants in a bridge is. Regular public const in the class? Make it a local (static?) variable in a function? Some tips would be appreciated!

Your solution using regular public const is best practice, they are immutable anyway and defined within the scope of your class.

@logmanoriginal logmanoriginal merged commit cb6ad7c into RSS-Bridge:master Dec 26, 2018
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Adds a new bridge for activity on boards and cards on the trello.com task management site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants