Skip to content

Set camelcased name in a correct place #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Set camelcased name in a correct place #15

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f24726c
Merge pull request #1 from Postmodum37/fix-multi-word-options
Postmodum37 Sep 16, 2019
dfcc051
Change name conversion place
Sep 16, 2019
235c003
Fix tests
Sep 16, 2019
f06314d
Add setting
Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/search_object/plugin/graphql.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@ module ClassMethods
KEYS = %i[type default description].freeze
def option(name, options = {}, &block)
config[:arguments] ||= {}

name = name.to_s.split('_').map(&:capitalize).join
name[0] = name[0].downcase

config[:arguments][name] = KEYS.inject({}) do |acc, key|
config[:arguments][name.to_s] = KEYS.inject({}) do |acc, key|
acc[key] = options[key] if options.key?(key)
acc
end
Expand Down Expand Up @@ -104,6 +100,9 @@ def field_options
resolver_class: self,
deprecation_reason: deprecation_reason,
arguments: (config[:arguments] || {}).inject({}) do |acc, (name, options)|
name = name.to_s.split('_').map(&:capitalize).join
name[0] = name[0].downcase

acc[name] = ::GraphQL::Schema::Argument.new(
name: name.to_s,
type: options.fetch(:type) { raise MissingTypeDefinitionError, name },
Expand Down