Skip to content

Don't override graphql-ruby's defaults for options that weren't specified, and pass default_value to argument when default option is specified #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2021
Merged

Don't override graphql-ruby's defaults for options that weren't specified, and pass default_value to argument when default option is specified #31

merged 2 commits into from
Feb 17, 2021

Conversation

haines
Copy link
Contributor

@haines haines commented Feb 16, 2021 •
edited
Loading

Fixes #30
Fixes #32

@coveralls
Copy link

coveralls commented Feb 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6dc4c29 on haines:camelize into 33f6dd2 on RStankov:master.

@haines haines changed the title Don't override graphql-ruby's defaults for options that weren't specified Don't override graphql-ruby's defaults for options that weren't specified, and pass default_value to argument when default option is specified Feb 16, 2021
@RStankov
Copy link
Owner

Thanks 🙏

@RStankov RStankov merged commit 67e842e into RStankov:master Feb 17, 2021
@haines haines mentioned this pull request Feb 17, 2021
Closed
@haines haines deleted the camelize branch February 17, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to specify default_value for options camelize defaults to false when not specified
3 participants
@haines @coveralls @RStankov