Skip to content

Conversation

meng-plus
Copy link
Contributor

@meng-plus meng-plus commented Sep 15, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

这段代码多余操作

你的解决方案是什么 (what is your solution)

清理删除

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Copy link

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/finsh/cmd.c

📊 Current Review Status (Last Updated: 2025-09-15 15:47 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Copy link
Contributor

@illustriousness illustriousness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这函数里面确实拷贝完什么都没做
可能作者之前写的时候想对当前的循环thread 做一个备份吧

@Maihuanyi
Copy link
Contributor

LGTM

@supperthomas supperthomas changed the title 清理掉无用的拷贝操作 [components][finsh] 清理掉无用的拷贝操作 Sep 17, 2025
@supperthomas supperthomas merged commit df8c29a into RT-Thread:master Sep 17, 2025
67 checks passed
@a1012112796
Copy link
Contributor

这函数里面确实拷贝完什么都没做 可能作者之前写的时候想对当前的循环thread 做一个备份吧

我也是这样认为的,前后明显有加锁保护。所以后面应该使用的是copy 到的 thread_info 而非 thread。

@a1012112796
Copy link
Contributor

这函数里面确实拷贝完什么都没做 可能作者之前写的时候想对当前的循环thread 做一个备份吧

我也是这样认为的,前后明显有加锁保护。所以后面应该使用的是copy 到的 thread_info 而非 thread。

我之前提过的另一个方案是直接改用 rt_object_for_each, 不过无人在意... #10605

@meng-plus meng-plus deleted the feat/clean_unused_code branch September 17, 2025 07:21
@Rbb666 Rbb666 added this to the v5.2.2 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants