[CPU/AARCH64] 增加libcpu/aarch64 KERNEL_ASPACE_START配置 #10757

messigogogo · 2025-09-28T01:57:09Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

#10441 修改了 KERNEL_VADDR_START 未定义时的默认值：由原先的 0x1000 改为 ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET。
这一调整在执行 rt_hw_board_init ->rt_hw_mmu_map_init -> rt_aspace_init 时，改变了非 rt-smart 模式下 MMU 虚拟地址与物理地址一一映射的逻辑,我方ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET = 0x80080000，导致 80080000 之前的地址段未被映射，从而引发启动失败。

你的解决方案是什么 (what is your solution)

修改回原来的写法

请提供验证的bsp和config (provide the config and bsp)

BSP:

.config:

action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2025-09-28T01:59:09Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：master
设置PR number为 \ Set the PR number to：10757

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

supperthomas · 2025-09-28T07:11:18Z

libcpu/aarch64/common/mmu.c

 /* restrict virtual address on usage of RT_NULL */
 #ifndef KERNEL_VADDR_START
-#define KERNEL_VADDR_START (ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET)
+#define KERNEL_VADDR_START 0x1000


这个其他平台也是这个值吗？可以kconfig配出这个值吗？
ARCH_RAM_OFFSET 和 ARCH_TEXT_OFFSET

以前一直都是0x1000，这个值和libcpu\aarch64\link.lds.S 关联，不能随便配，代表内存的起始地址

你可以通过改.config来实现等价这个值，固定某个值估计不太解耦。我估计其他平台这里可能不一样。

supperthomas · 2025-09-28T08:06:33Z

@GuEe-GUI @BernardXiong

GuEe-GUI · 2025-09-28T08:28:24Z

ARCH_RAM_OFFSET 和 ARCH_TEXT_OFFSET配置不出来就再加个配置配置出来，反正不要写死

messigogogo · 2025-09-28T09:36:05Z

ARCH_RAM_OFFSET 和 ARCH_TEXT_OFFSET配置不出来就再加个配置配置出来，反正不要写死

我这个值配出来了，加起来是0x8008000,并且需要正确链接到.ld文件里，但是rt_hw_board_init ->rt_hw_mmu_map_init -> rt_aspace_init要用的这个值，范围需要包含我前面的地址，原本的范围是0x1000-0x?现在成了0x80080000-0x?，假设有个串口寄存器0x28000000,如果不走rt_aspace_init流程我这个地址就写不进去。您看有没有更好的方案，不把这两个需求耦合在一起

GuEe-GUI · 2025-09-28T09:45:53Z

考虑使用 rt_ioremap 访问外设么？

如果存在比较大的修改，也可以考虑在 BSP 的配置中强制对 KERNEL_VADDR_START 进行配置：

config KERNEL_VADDR_START
    hex
    default 0x1000

messigogogo · 2025-09-29T06:30:55Z

考虑使用 rt_ioremap 访问外设么？

如果存在比较大的修改，也可以考虑在 BSP 的配置中强制对 KERNEL_VADDR_START 进行配置：
config KERNEL_VADDR_START
    hex
    default 0x1000

这种改方法很不方便，因为我也适配了rtsmart，我开启rtsmart配置时，也需要rtsmart的默认值0xffff000000000000，如果在我的bsp里强加这样一个配置就会和libcpu的Kconfig的值冲突，
config KERNEL_VADDR_START
hex
default 0x1000
depends on !RT_USING_SMART，
加载不下来rtsmart的默认值。这个值能否释放出来不和rtsmart强相关？

GuEe-GUI · 2025-09-29T08:57:44Z

这样可以么？

if RT_USING_SMART
[...]
endif

messigogogo · 2025-09-29T09:57:54Z

这样可以么？
if RT_USING_SMART
[...]
endif

有试过

GuEe-GUI · 2025-09-29T10:00:06Z

那就再添加一个配置宏，如果没有这个宏就默认为(ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET)

messigogogo · 2025-09-29T11:46:53Z

那就再添加一个配置宏，如果没有这个宏就默认为(ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET)

有没有示例写法，我试一下，KERNEL_VADDR_START，不好被覆盖，我也不好每次开关smart都要手写

GuEe-GUI · 2025-09-29T12:31:07Z

类似这样：

#ifndef KERNEL_VADDR_START
#ifdef  KERNEL_ASPACE_START
#define KERNEL_VADDR_START KERNEL_ASPACE_START
#else
#define KERNEL_VADDR_START (ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET)
#endif
#endif /* KERNEL_VADDR_START */

KERNEL_ASPACE_START 可以由 BSP 自行定义

messigogogo · 2025-09-30T01:53:56Z

类似这样：

#ifndef KERNEL_VADDR_START
#ifdef  KERNEL_ASPACE_START
#define KERNEL_VADDR_START KERNEL_ASPACE_START
#else
#define KERNEL_VADDR_START (ARCH_RAM_OFFSET + ARCH_TEXT_OFFSET)
#endif
#endif /* KERNEL_VADDR_START */

KERNEL_ASPACE_START 可以由 BSP 自行定义

已修改

Rbb666 · 2025-10-09T04:27:28Z

@messigogogo 麻烦规范下PR的标题吧，请说明清楚PR修改了什么内容

messigogogo added 2 commits September 28, 2025 09:46

debuge mmu

e93977c

debuge mmu

1ca1702

messigogogo changed the title ~~aarch64 mmu修复~~ [CPU/AARCH64] 修复 MMU Sep 28, 2025

github-actions bot added BSP Arch: ARM/AArch64 BSP related with arm libcpu BSP: Phytium BSP related with Phytium labels Sep 28, 2025

supperthomas approved these changes Sep 28, 2025

View reviewed changes

supperthomas requested changes Sep 28, 2025

View reviewed changes

supperthomas requested a review from BernardXiong September 28, 2025 08:06

supperthomas mentioned this pull request Sep 28, 2025

[Bug] rt-thread crack oops with command 'list_kmem' #10686

Open

update

7233a4a

supperthomas approved these changes Sep 30, 2025

View reviewed changes

supperthomas assigned BernardXiong Oct 4, 2025

Rbb666 added this to the v5.2.2 milestone Oct 5, 2025

Rbb666 approved these changes Oct 9, 2025

View reviewed changes

messigogogo changed the title ~~[CPU/AARCH64] 修复 MMU~~ [CPU/AARCH64] 增加aarch64 KERNEL_ASPACE_START配置 Oct 9, 2025

messigogogo changed the title ~~[CPU/AARCH64] 增加aarch64 KERNEL_ASPACE_START配置~~ [CPU/AARCH64] 增加libcpu/aarch64 KERNEL_ASPACE_START配置 Oct 9, 2025

Rbb666 merged commit cc72712 into RT-Thread:master Oct 10, 2025
55 checks passed

[CPU/AARCH64] 增加libcpu/aarch64 KERNEL_ASPACE_START配置 #10757

[CPU/AARCH64] 增加libcpu/aarch64 KERNEL_ASPACE_START配置 #10757

Conversation

messigogogo commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Sep 28, 2025

🛠 操作步骤 | Steps

Uh oh!

supperthomas Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

messigogogo Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

supperthomas Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

supperthomas commented Sep 28, 2025

Uh oh!

GuEe-GUI commented Sep 28, 2025

Uh oh!

messigogogo commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuEe-GUI commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

messigogogo commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuEe-GUI commented Sep 29, 2025

Uh oh!

messigogogo commented Sep 29, 2025

Uh oh!

GuEe-GUI commented Sep 29, 2025

Uh oh!

messigogogo commented Sep 29, 2025

Uh oh!

GuEe-GUI commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

messigogogo commented Sep 30, 2025

Uh oh!

Rbb666 commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

messigogogo commented Sep 28, 2025 •

edited

Loading

supperthomas Sep 28, 2025 •

edited

Loading

messigogogo Sep 28, 2025 •

edited

Loading

messigogogo commented Sep 28, 2025 •

edited

Loading

GuEe-GUI commented Sep 28, 2025 •

edited

Loading

messigogogo commented Sep 29, 2025 •

edited

Loading

GuEe-GUI commented Sep 29, 2025 •

edited

Loading