Skip to content

Conversation

zhkag
Copy link
Member

@zhkag zhkag commented Jun 16, 2023

拉取/合并请求描述:(PR description)

[
修复 bsp/hk32/hk32f030c8-mini/Kconfig 中的 source 文件名称错误
修复 bsp/loongson/ls1cdev/Kconfig 中的 RT_USING_CAN 循环依赖
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zhkag
Copy link
Member Author

zhkag commented Jun 16, 2023

#7682

@supperthomas
Copy link
Member

scons --pyconfig-silent 加一下,CI好检查

@zhkag
Copy link
Member Author

zhkag commented Jun 16, 2023

scons --pyconfig-silent 加一下,CI好检查

可以合的 我看 ci 的日志了,这个合了之后 重启一下另一个 ci 就行了

@supperthomas supperthomas added the +1 Agree +1 label Jun 16, 2023
@supperthomas
Copy link
Member

#7530

@mysterywolf mysterywolf added +2 Agree +2 and removed wait_+2 wait for "+2" to confirm labels Jun 17, 2023
@mysterywolf mysterywolf merged commit 01fdd22 into RT-Thread:master Jun 17, 2023
supperthomas added a commit to supperthomas/rt-thread that referenced this pull request Jun 18, 2023
* [bsp/renesas/ebf_qi_min_6m5]use fsp v4.4.0, add sci spi config item, add sci i2c driver, update README.

* [simulator] 添加 simulator in Linux ci (RT-Thread#7664)

* [adc] remove dead code

The variable result_str is never used after this assignment.

* [msh] fix offset used before range check

These uses of offset 'cmd0_size' should follow the range check.

* [libc][ctime] move null pointer check before dereference

This null check was redundant because the pointer timep was
dereferenced in any case.

* [components][time.h]Fixed undefined macro TIMER_ABSTIME

* 向 wch-riscv-bsp 添加 drv_common.c/.h 文件 (RT-Thread#7671)

* BSP support menuconfig for lm3s9b9x

* BSP support menuconfig for lms38962

* Modify code format

* [cpp] support rt-thread CPP wrapper sub-switch macros

* [cpp] attach CXXFLAGS to reduce the resource consumptions

* [bsp][ch32-rsicv][sconscript] add drv_common.c

attach bf45948

* [bsp] BSP support menuconfig for sam7x

* [bsp] BSP support menuconfig for fujitsu

* [bsp][stm32u575] add ADC support

* [bsp][lpc55sxx]update: update keil default project

1.update keil default project
2.add rtduino aht10 demo

* [menuconfig] 修复 menuconfig 相关问题 (RT-Thread#7686)

Co-authored-by: supperthomas <78900636@qq.com>

* [finsh] 添加 RT_Device_Class_Bus 对应的描述字符串

* [ch32][risc-v][bsp] update drv_common for wch risc-v bsp

* [issue] templete

---------

Co-authored-by: vandoul <vandoul@ticks.cn>
Co-authored-by: zhkag <zhkag@foxmail.com>
Co-authored-by: Mingjie Shen <shen497@purdue.edu>
Co-authored-by: yangjie11 <yangjiexaut@126.com>
Co-authored-by: self-confident neko <45762837+muaxiaohei@users.noreply.github.com>
Co-authored-by: dejavudwh <daweihucs@outlook.com>
Co-authored-by: Meco Man <920369182@qq.com>
Co-authored-by: zst123 <zst123@users.noreply.github.com>
Co-authored-by: Shicheng Chu <1468559561@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+1 Agree +1 +2 Agree +2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[新手任务][menuconfig] 尝试给 一些bsp添加Kconfig .config等文件,方便menuconfig

3 participants