-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KG2.8.0 edges with a qualified_object_direction, but no qualified_predicate #250
Comments
it looks like all of the 2.4 million affected edges have the
I wonder if it would be worth adding a temporary patch in the KG2c build code that fixes this (by simply giving all such edges a perhaps @sundareswarpullela would be interested in writing such a patch? |
Sure! I can pick this up @amykglen |
Thank you for the alert, Amy! I'll make the correction in KG2pre |
great, thanks @sundareswarpullela! I created an issue in the RTX repo for the patch so you can link your commits to it: RTXteam/RTX#1942 |
A lot of entries in predicate-remap.yaml were missing qualified_predicate, so I added those. Hopefully, this solves this issue. I will verify in next build. |
I noticed that this edge in KG2.8.0c (which comes from the KG2.8.0pre edge with ID
UMLS:C0043552---SEMMEDDB:stimulates---None---None---increased---UMLS:C0006809---SEMMEDDB:
) has aqualified_object_direction
, but noqualified_predicate
:I don't think this is valid, at least according to the predicate transformations Sierra provided? those transformations seem to suggest this edge should have a
qualified_predicate
of "causes" and anobject_aspect
of "activity_or_abundance".it looks like there are 2.4 million such edges in KG2.8.0c (that have a
qualified_object_direction
but do not have aqualified_predicate
) based on this neo4j query:based on the KG2pre ID of the specific edge reported above, it seems that the
qualified_predicate
was already missing in KG2pre vs. being lost during the KG2c build process, so that's why I'm writing up this issue in this repo.The text was updated successfully, but these errors were encountered: