FEA: add SimpleX in general model #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wicknight
approved these changes
May 10, 2022
Wicknight
requested changes
May 27, 2022
| super(SimpleX, self).__init__(config, dataset) | ||
|
|
||
| # Get user transaction history | ||
| self.history_item_id, _, self.history_item_len = dataset.history_item_matrix() |
There was a problem hiding this comment.
在gpu运行时会报错，需要在这里添加self.history_item_id = self.history_item_id.to(self.device)以及self.history_item_len=self.history_item_len.to(self.device)
| pos_item = pos_item[0:user_number] | ||
| # history_len | ||
| history_len = self.history_item_len[user] | ||
| history_len = torch.minimum(history_len, torch.zeros(1)+self.history_len) |
There was a problem hiding this comment.
history_len=torch.minimum(history_len, torch.zeros(1, device=self.device)+self.history_len)
| item_seq = self.history_item_id[user] | ||
| item_seq = item_seq[:, :self.history_len] | ||
| item_seq_len = self.history_item_len[user] | ||
| item_seq_len = torch.minimum(item_seq_len, torch.zeros(1)+self.history_len) |
There was a problem hiding this comment.
item_seq_len=torch.minimum(item_seq_len, torch.zeros(1, device=self.device)+self.history_len)
| item_seq = self.history_item_id[user] | ||
| item_seq = item_seq[:, :self.history_len] | ||
| item_seq_len = self.history_item_len[user] | ||
| item_seq_len = torch.minimum(item_seq_len, torch.zeros(1)+self.history_len) |
There was a problem hiding this comment.
item_seq_len=torch.minimum(item_seq_len, torch.zeros(1, device=self.device)+self.history_len)
There was a problem hiding this comment.
ok，已进行修改并已提交。除此之外还修改了predict方法与full_sort_predict方法的部分变量名称让变量更通俗易懂
Wicknight
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add SimpleX in general model