Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Issue with Zf2Whoops module #90

Closed
Devidia opened this issue May 30, 2013 · 12 comments
Closed

Compatibility Issue with Zf2Whoops module #90

Devidia opened this issue May 30, 2013 · 12 comments

Comments

@Devidia
Copy link

Devidia commented May 30, 2013

The match route does not works when we using the Zf2Whoops module.

@RWOverdijk
Copy link
Owner

That's a shame. We're waiting until the absolute last moment to figure out if the request was for an asset. Unless we work around their priority it would seem modules are simply not compatible.

@Ocramius
Copy link
Contributor

By the way - why does the whoops module intercept 404s? Shouldn't it just
handle 5xx exceptions?
On 30 May 2013 13:36, "Wesley Overdijk" notifications@github.com wrote:

That's a shame. We're waiting until the absolute last moment to figure out
if the request was for an asset. Unless we work around their priority it
would seem modules are simply not compatible.


Reply to this email directly or view it on GitHubhttps://github.com//issues/90#issuecomment-18674957
.

@Devidia
Copy link
Author

Devidia commented May 30, 2013

No, 404 also.

@Ocramius
Copy link
Contributor

@Devidia and there you got your problem ;) Either Whoops stops handling 404s or AM cannot kick in :)

I honestly don't think 404s should be stopped from bubbling up.

@Devidia
Copy link
Author

Devidia commented May 30, 2013

I just wanted to share this information with you. Might be, it's a good idea to put a "Warning" about that in your tutorial. Because, I spent many time to understand this compatibility issue. that's it.

Anyway, thank you for your good job.

@Ocramius
Copy link
Contributor

@Devidia well, you could consider adding a conflict section to composer.json in their repo until they fix it (not here, it's not an issue of this module IMO)

@RWOverdijk could be closed

@Devidia please bring it up on Zf2Whoops with the considerations collected here.

@RWOverdijk
Copy link
Owner

@Ocramius We could change the priority. So if we can't find anything, maybe they can then catch the 404. Then they would play nice together.

@Ocramius
Copy link
Contributor

@RWOverdijk I don't think it has to be handled here. Zf2Whoops should still let the exception reach the application.finish

@RWOverdijk
Copy link
Owner

We should at least let them know this issue exists, no?

@Ocramius
Copy link
Contributor

Ocramius commented Jun 3, 2013

@RWOverdijk opened ghislainf/zf2-whoops#2 - this one can be closed

@ghislainf
Copy link

The module is fixed, it do not intercepts the 404 now. @Ocramius you're right, it was no any interest.

@Ocramius
Copy link
Contributor

Ocramius commented Jun 9, 2013

@ghislainf thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants