-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility Issue with Zf2Whoops module #90
Comments
That's a shame. We're waiting until the absolute last moment to figure out if the request was for an asset. Unless we work around their priority it would seem modules are simply not compatible. |
By the way - why does the whoops module intercept 404s? Shouldn't it just
|
No, 404 also. |
@Devidia and there you got your problem ;) Either Whoops stops handling 404s or AM cannot kick in :) I honestly don't think 404s should be stopped from bubbling up. |
I just wanted to share this information with you. Might be, it's a good idea to put a "Warning" about that in your tutorial. Because, I spent many time to understand this compatibility issue. that's it. Anyway, thank you for your good job. |
@Devidia well, you could consider adding a @RWOverdijk could be closed @Devidia please bring it up on Zf2Whoops with the considerations collected here. |
@Ocramius We could change the priority. So if we can't find anything, maybe they can then catch the 404. Then they would play nice together. |
@RWOverdijk I don't think it has to be handled here. Zf2Whoops should still let the exception reach the |
We should at least let them know this issue exists, no? |
@RWOverdijk opened ghislainf/zf2-whoops#2 - this one can be closed |
The module is fixed, it do not intercepts the 404 now. @Ocramius you're right, it was no any interest. |
@ghislainf thanks! |
The match route does not works when we using the Zf2Whoops module.
The text was updated successfully, but these errors were encountered: