-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 2.7.0 #220
chore: release 2.7.0 #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nit-pickings. Looks good to me. Thanks, @Radi85, for the patch.
Apart from all this code, amidst the pandemic, shifting and everything else, how are you @Radi85, and how is everything at home? |
Thanks for your check! @abhiabhi94 |
I am finally settling down in the new apartment and getting back to my old routine slowly 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
I have recently brought a dog home. She has messed up my routine a lot. But, the other parts with her seem enjoyable at the moment. She keeps me distracted due to her demands for attention. 😄 |
I think this need to be merged only after #226.
20dd117
to
821a291
Compare
travis is taking forever to start this! 💢 |
I see a lot of |
I think quota issue. Can you please review/approve the PR so that I can proceed with the release once the pipeline is done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Radi85, for the updates back and forth.
hey @Radi85, should we consider switching to github actions? the only point of contention being the release. if you want the release process to still be automated, you probably will have to add your PyPI password as github secret. i have some trust issues with github since it has happened several times that secrets have been leaked. i would suggest switching to manual releases for the time being, and i can take that responsibility for now, if there's an issue with it. in case you're okay with using github secrets, then you can add the secret to the repository. i will make a pull-request soon, and we can continue this discussion there. |
Codecov Report
@@ Coverage Diff @@
## develop #220 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 55 55
Lines 1969 1969
Branches 158 158
========================================
Hits 1967 1967
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, 🚀 finally, 2.7.0
is going to be released 🥳 . Thanks @Radi85 for your efforts.
closes #218