Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 2.7.0 #220

Merged
merged 1 commit into from
Aug 29, 2021
Merged

chore: release 2.7.0 #220

merged 1 commit into from
Aug 29, 2021

Conversation

Radi85
Copy link
Owner

@Radi85 Radi85 commented Aug 17, 2021

closes #218

@Radi85 Radi85 requested a review from abhiabhi94 August 17, 2021 12:06
docs/source/usage.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@abhiabhi94 abhiabhi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nit-pickings. Looks good to me. Thanks, @Radi85, for the patch.

@abhiabhi94
Copy link
Collaborator

Apart from all this code, amidst the pandemic, shifting and everything else, how are you @Radi85, and how is everything at home?

@Radi85
Copy link
Owner Author

Radi85 commented Aug 18, 2021

Thanks for your check! @abhiabhi94

@Radi85
Copy link
Owner Author

Radi85 commented Aug 18, 2021

Apart from all this code, amidst the pandemic, shifting and everything else, how are you @Radi85, and how is everything at home?

I am finally settling down in the new apartment and getting back to my old routine slowly 😄
How about you? How's life going there?

@Radi85 Radi85 requested a review from abhiabhi94 August 18, 2021 08:08
abhiabhi94
abhiabhi94 previously approved these changes Aug 18, 2021
Copy link
Collaborator

@abhiabhi94 abhiabhi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

@abhiabhi94
Copy link
Collaborator

How about you? How's life going there?

I have recently brought a dog home. She has messed up my routine a lot. But, the other parts with her seem enjoyable at the moment. She keeps me distracted due to her demands for attention. 😄

@abhiabhi94 abhiabhi94 dismissed their stale review August 18, 2021 23:39

I think this need to be merged only after #226.

@Radi85 Radi85 force-pushed the staging branch 2 times, most recently from 20dd117 to 821a291 Compare August 19, 2021 08:14
@Radi85 Radi85 requested a review from abhiabhi94 August 19, 2021 08:27
@abhiabhi94
Copy link
Collaborator

travis is taking forever to start this! 💢

@abhiabhi94
Copy link
Collaborator

abhiabhi94 commented Aug 19, 2021

I see a lot of 403 status on the developer console for the request GET https://api.travis-ci.com/v3/build_backups?repository_id=14692409&offset=0&limit=1 on the page https://app.travis-ci.com/github/Radi85/Comment/jobs/532506604. Maybe the quota for the builds has been exhausted on travis or it has something to do with the integration between travis and github?

@Radi85
Copy link
Owner Author

Radi85 commented Aug 19, 2021

Maybe the quota for the builds has been exhausted on travis or it has something to do with the integration between travis and github?

I think quota issue. Can you please review/approve the PR so that I can proceed with the release once the pipeline is done?

abhiabhi94
abhiabhi94 previously approved these changes Aug 19, 2021
Copy link
Collaborator

@abhiabhi94 abhiabhi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Radi85, for the updates back and forth.

@abhiabhi94
Copy link
Collaborator

hey @Radi85, should we consider switching to github actions? the only point of contention being the release. if you want the release process to still be automated, you probably will have to add your PyPI password as github secret. i have some trust issues with github since it has happened several times that secrets have been leaked. i would suggest switching to manual releases for the time being, and i can take that responsibility for now, if there's an issue with it. in case you're okay with using github secrets, then you can add the secret to the repository. i will make a pull-request soon, and we can continue this discussion there.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #220 (6c9c2eb) into develop (ae75a9a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #220   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           55       55           
  Lines         1969     1969           
  Branches       158      158           
========================================
  Hits          1967     1967           
  Misses           1        1           
  Partials         1        1           
Impacted Files Coverage Δ
comment/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae75a9a...6c9c2eb. Read the comment docs.

Copy link
Collaborator

@abhiabhi94 abhiabhi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, 🚀 finally, 2.7.0 is going to be released 🥳 . Thanks @Radi85 for your efforts.

@Radi85 Radi85 merged commit d006af6 into develop Aug 29, 2021
@Radi85 Radi85 deleted the staging branch August 29, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support django 3.2
3 participants