Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to github actions for CI #228

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

abhiabhi94
Copy link
Collaborator

@abhiabhi94 abhiabhi94 commented Aug 19, 2021

  • add separate environment in tox for linters and docs.
  • switch to codecov for coverage since coveralls doesn't play well with github-actions.

Thanks travis for their service till now.

closes actions/toolkit#223.

@abhiabhi94 abhiabhi94 force-pushed the ci/switch-to-github-actions branch 4 times, most recently from af52412 to a353fca Compare August 20, 2021 04:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@a539232). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     actions/toolkit#228   +/-   ##
==========================================
  Coverage           ?   99.89%           
==========================================
  Files              ?       55           
  Lines              ?     1969           
  Branches           ?      158           
==========================================
  Hits               ?     1967           
  Misses             ?        1           
  Partials           ?        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a539232...e4623e7. Read the comment docs.

@abhiabhi94
Copy link
Collaborator Author

Hey @Radi85, you may have to set up the repository on codecov, although their bot is still commenting so i guess it may not be required.

I haven't added anything related to release as of now, please let me know your thoughts regarding the potential approaches as stated in #220 (comment). any new ideas are welcome.

@abhiabhi94 abhiabhi94 requested a review from Radi85 August 20, 2021 05:05
@Radi85
Copy link
Owner

Radi85 commented Aug 20, 2021

Hey @abhiabhi94, well done. Thanks a lot for your time.
I have updated the settings, removed travis things and so on. I also synchronised codecov with the repo.
I would like to add the release at least for testing pypi and the main one will be kept to manually for now. Can you please add the test pypi release to the CI?

@abhiabhi94 abhiabhi94 force-pushed the ci/switch-to-github-actions branch 3 times, most recently from 6cc0172 to 8a33e69 Compare August 20, 2021 20:40
@abhiabhi94
Copy link
Collaborator Author

I have updated the settings, removed travis things and so on. I also synchronised codecov with the repo.

Thank you 🎉 for the updates.

I would like to add the release at least for testing pypi and the main one will be kept to manually for now. Can you please add the test pypi release to the CI?

I have updated the patch to include the release workflow. The aim is to release to test PyPI servers when there is tag pushed on the master branch. This was what I could gather from our previous travis workflow. Please inform if this doesn't seem suffice for our use-case or anything else needs attention. Happy to make the changes.

You probably would have to setup the credentials on Github, in case you haven't done it yet. This guide could be helpful.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@abhiabhi94 abhiabhi94 force-pushed the ci/switch-to-github-actions branch 2 times, most recently from 1ffb28a to 3fb3e72 Compare August 23, 2021 15:55
- add separate environment in tox for linters and docs.
- switch to codecov for coverage since coveralls doesn't play well with github-actions.
- add wheels and setuptools to the environment.

Thanks travis for their service till now.
@abhiabhi94
Copy link
Collaborator Author

abhiabhi94 commented Aug 25, 2021

hey @Radi85, is their any other change that is required in this patch or is this now good to go?

@Radi85
Copy link
Owner

Radi85 commented Aug 29, 2021

hey @Radi85, is their any other change that is required in this patch or is this now good to go?

So far I think we are good to go. Let's see how things go and later on we decide whether adding the main release or just keeping it manually.

@abhiabhi94 thanks for the good work.

@Radi85 Radi85 merged commit ae75a9a into Radi85:develop Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants