Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sleep from pbar update loop #347

Merged
merged 1 commit into from
Apr 7, 2021
Merged

remove sleep from pbar update loop #347

merged 1 commit into from
Apr 7, 2021

Conversation

mkolopanis
Copy link
Member

remove sleep introduced in last PR. Turns out it serializes the execution of the task loop,
Ran reference sim 1.1 before and after this change and the before is very slow, but after completes in ~.03 minutes same as before last PR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #347 (a43e80e) into main (13bb52b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   99.02%   99.02%   -0.01%     
==========================================
  Files          13       13              
  Lines        1945     1943       -2     
==========================================
- Hits         1926     1924       -2     
  Misses         19       19              
Impacted Files Coverage Δ
pyuvsim/uvsim.py 98.45% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bb52b...a43e80e. Read the comment docs.

@mkolopanis
Copy link
Member Author

@bhazelton I think this will require admin to merge because I've removed covered lines, but I don't think it is reasonable to serialize a uvtask to once a second.

@bhazelton
Copy link
Member

bhazelton commented Apr 6, 2021

I don't think you do -- the test that's failing is not a required test for exactly this reason.

@mkolopanis
Copy link
Member Author

mkolopanis commented Apr 6, 2021 via email

Copy link
Contributor

@aelanman aelanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@mkolopanis mkolopanis merged commit b94f5cb into main Apr 7, 2021
@mkolopanis mkolopanis deleted the remove_sleep branch April 7, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants