Problem on admin/media.php

[link0087]

Hello,

i would like to introduce a little doubt that i have on this plugin, in particular on the media.php file.
I have WP Plugin version 3.0, on method "a_get_list" there is a problem on the return json.
on the if ( isset( $_POST['post_types'] ) && !empty( $_POST['post_types'] ) ) , so if i specified some post type on the regeneration screen to intend, the query in this piece of code, return a count of id:

$attachments = $wpdb->get_var( "SELECT count(ID)
FROM $wpdb->posts
WHERE 1 = 1
AND post_type = 'attachment'
$whichmimetype
AND
(post_parent = 0
OR
post_parent IN (
SELECT DISTINCT ID
FROM $wpdb->posts
WHERE post_type IN ('".implode( "', '", $_POST['post_types'] )."')
)) " );

this seems correct but is not compatible with the return code:

SIS_Admin_Main::displayJson( array( 'total' => count( $attachments ) ) );

in this case the plugin failed, because of a count of a count that is still "1".

i hope to be clear on this mail not easy to explaine for me in english :)

Please feel free to reply me back if you need more information.

Thank you so much

Fabio Sirchia

[Rahe]

hi !
Thank you for the feedback, effectively this will not work :/
If you want you can make a pull request and I will accept it :).

This will be merged on the next version of the plugin.
Thank you !

[link0087]

Sent the pull request all yours :)

[Rahe]

Pull request merged, thank you !