Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the atmega8u2 chip #160

Closed
wants to merge 0 commits into from
Closed

add the atmega8u2 chip #160

wants to merge 0 commits into from

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Mar 9, 2021

I confirmed that this compiles. Once the avr-device version is bumped and a new crate is built, we can remove the revision pins in the various Cargo.tomls and this "should" be ready to ship.

@Rahix Rahix added the mcu-support Support for a new Microcontroller label Mar 9, 2021
arduino-hal/Cargo.toml Outdated Show resolved Hide resolved
mcu/atmega-hal/src/port.rs Outdated Show resolved Hide resolved
@drmorr0 drmorr0 force-pushed the next branch 3 times, most recently from 9490ce7 to 0451af3 Compare March 10, 2021 06:30
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor thing which I commented below. I'll release a new version of avr-device soon, then we can merge this here.

avr-specs/avr-atmega8u2.json Outdated Show resolved Hide resolved
@Rahix
Copy link
Owner

Rahix commented Mar 10, 2021

(CI failures just due to the unreleased version of avr-device)

@Rahix Rahix added the waiting-for-avr-device Waiting for a new release of `avr-device` label Mar 10, 2021
@drmorr0 drmorr0 closed this Mar 25, 2021
@Rahix
Copy link
Owner

Rahix commented Mar 25, 2021

Hm, why did you close this PR? Was is by accident? You seem to have removed all changes from this PR by a force-push?

I'd still go ahead with it once the next release of avr-device hits.

@drmorr0
Copy link
Contributor Author

drmorr0 commented Mar 25, 2021

Ugh. Yea, my local git repo got messed up and I guess I screwed this up. I re-opened it in #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mcu-support Support for a new Microcontroller waiting-for-avr-device Waiting for a new release of `avr-device`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants