-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some formatting and grammar improvements. #37
Open
adymitruk
wants to merge
1
commit into
RajSolai:master
Choose a base branch
from
adymitruk:fix-grammar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ class TesseractTrigger : Object { | |
public void accept_files_fromchooser () { | ||
portal.open_file.begin ( | ||
null, | ||
"Select an Image to perform OCR !", | ||
"Select an image to perform OCR !", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as in the comment above. |
||
null, | ||
null, | ||
null, | ||
|
@@ -54,7 +54,7 @@ class TesseractTrigger : Object { | |
async void read_image (string file_path) { | ||
var lang_service = new LanguageService () ; | ||
string lang = lang_service.get_pref_language () ; | ||
label.label = "Reading Image" ; | ||
label.label = "Reading image" ; | ||
Idle.add (read_image.callback) ; | ||
yield ; | ||
try { | ||
|
@@ -64,12 +64,12 @@ class TesseractTrigger : Object { | |
copy_to_clipboard () ; | ||
} else { | ||
print ("Error is " + err + " status is " + stat.to_string ()) ; | ||
label.label = "Error Reading Image" ; | ||
label.label = "Error reading image" ; | ||
} | ||
} catch (Error e) { | ||
critical (e.message) ; | ||
if (e.code == 8) { | ||
label.label = "Dependencies Not Found" ; | ||
label.label = "Dependencies not found" ; | ||
} | ||
} | ||
} | ||
|
@@ -80,9 +80,9 @@ class TesseractTrigger : Object { | |
FileUtils.get_contents (out_path + ".txt", out text_output) ; | ||
if (text_output.length > 0) { | ||
clipboard.set_text (text_output, text_output.length) ; | ||
label.label = "Checkout Clipboard :)" ; | ||
label.label = "Check out the clipboard :)" ; | ||
} else { | ||
label.label = "Error Reading Image" ; | ||
label.label = "Error reading image" ; | ||
} | ||
} catch (Error e) { | ||
print (e.message) ; | ||
|
@@ -98,7 +98,7 @@ class TesseractTrigger : Object { | |
clipboard.request_image (clipboard_callback) ; | ||
} else { | ||
print ("no image found in clipboard") ; | ||
label.label = "No Image found in Clipboard" ; | ||
label.label = "No image found in clipboard" ; | ||
} | ||
} else { | ||
if (session == "x11") { | ||
|
@@ -138,7 +138,7 @@ class TesseractTrigger : Object { | |
uri = portal.take_screenshot.end (res) ; | ||
string path = GLib.Filename.from_uri (uri, null) ; | ||
read_image.begin (path, (obj, res) => { | ||
print ("Taking Screenshot") ; | ||
print ("Taking screenshot") ; | ||
}) ; | ||
} catch (Error e) { | ||
critical (e.message) ; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also remove a space between word
image
and a question mark