Add tests for Windows specific Proc argument quoting #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugexe
reviewed
Apr 23, 2020
|
|
||
| plan 21; | ||
|
|
||
| if !$*DISTRO.is-win { |
There was a problem hiding this comment.
What about JVM on windows? (it did work at one time)
There was a problem hiding this comment.
Good catch! Would you disable these tests altogether on JVM or only the failing ones?
There was a problem hiding this comment.
If NativeCall doesn't work on JVM it is probably a moot point. Do you happen to have a hunch on which ones would might fail on JVM?
There was a problem hiding this comment.
My guess is, that all the test-run-verbatim tests will fail because the JVM will just quote the things anyways (because the thing we call is not a .bat file).
There was a problem hiding this comment.
Now all of these tests are skipped on the JVM. I guess there isn't much point in testing JVMs internal quoting behavior.
patrickbkr
force-pushed
the
problem-solving20
branch
from
cd5ca24
to
e9e10bc
Compare
patrickbkr
force-pushed
the
problem-solving20
branch
from
e9e10bc
to
0955070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for Raku/problem-solving#20.