feat: Refactor core logic and enhance security #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a major refactoring of core application logic to improve modularity, performance, and security. Key changes include: - **Centralized Core Utilities:** - A new `core` application has been updated to house shared utilities. - `CustomLimitOffsetPagination` is now centralized in `core.pagination`. - A generic `bump_token_version` utility in `core.utils.auth` now handles token versioning for both User and Company models and includes cache invalidation. - **Performance and Security Enhancements:** - Implemented a caching layer for the authentication process. Authenticated user and company instances are now cached to reduce database queries. - Strengthened password security by setting Argon2 as the default password hasher. - **Code Simplification:** - Removed custom email validators in favor of relying on database integrity constraints (`try...except IntegrityError`), making the validation logic more robust and reducing boilerplate code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a major refactoring of core application logic to improve modularity, performance, and security.
Key changes include:
Centralized Core Utilities:
coreapplication has been updated to house shared utilities.CustomLimitOffsetPaginationis now centralized incore.pagination.bump_token_versionutility incore.utils.authnow handles token versioning for both User and Company models and includes cache invalidation.Performance and Security Enhancements:
Implemented a caching layer for the authentication process. Authenticated user and company instances are now cached to reduce database queries.
Strengthened password security by setting Argon2 as the default password hasher.
Code Simplification:
try...except IntegrityError), making the validation logic more robust and reducing boilerplate code.Other changes: