-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 7: tangent unit sphere clarity #142
Comments
I share your confusion for the exact same reasons. Took me a while to comprehend the illustration. |
Will address this in #263. |
Ah, this is supposed to be the open one. |
hollasch
pushed a commit
that referenced
this issue
Mar 23, 2020
Figure [rand-vector], In One Weekend. Also update preceding text. Fixes #142
Fixed in #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In chapter 7, we have the sentences:
"Pick a random point s from the unit radius sphere that is tangent to the hitpoint, and send a ray
from the hitpoint p to the random point s. That sphere has center (p+N)."
After puzzling over this for a while (even with the picture) it finally dawned on me that it is the unit sphere itself that is tangent to the hitpoint p, and not the point s. It seems obvious in retrospect, but I think this point could be made clearer. I think my confusion comes from two facts:
To trace my confusion: I originally imagined that the unit sphere was at the center of the sphere being hit and could therefore approximate a sphere of any size; then I imagined the unit sphere's center was at hitpoint p and we were looking for a point on the sphere tangent to it (which made no sense to me); and then finally I partially understood the unit sphere's tangency to p, but still thought point s would be secant to p and that the modifier "tangent" applied to s and not the sphere.
The text was updated successfully, but these errors were encountered: