Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAXFLOAT should be rewritten as Infinity #195

Closed
trevordblack opened this issue Sep 18, 2019 · 3 comments
Closed

MAXFLOAT should be rewritten as Infinity #195

trevordblack opened this issue Sep 18, 2019 · 3 comments
Assignees
@ronaldfw
Labels
area: code
Milestone
v3

Comments

@trevordblack
Copy link
Collaborator

MAXFLOAT represents the largest possible floating point (32 or 64 bit) number.
This will almost never present a problem in practice, but the correct formulation here is with floating point infinity.
@trevordblack trevordblack added this to the post-v2 milestone Sep 18, 2019
@hollasch
Copy link
Collaborator

Agreed.

@ronaldfw ronaldfw self-assigned this Sep 24, 2019
ronaldfw added a commit that referenced this issue Sep 25, 2019
@ronaldfw
Replace MAXFLOAT with (portable) infinity
9a3cacb 
Fixes #195 and should get us get closer to portable code across Windows/Linux/Mac.

Only tested on Mac. Will test other platforms once all obvious portability issues have been fixed and will then take care of any remaining issues.
@ronaldfw
Copy link
Contributor

Fixed on future branch. Will keep this issue open until this is merged with master.

@hollasch
Copy link
Collaborator

Merged into the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronaldfw ronaldfw

Labels
area: code
Projects
None yet
Milestone
v3
Development

No branches or pull requests
3 participants
@hollasch @trevordblack @ronaldfw