Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book Two moving_sphere: aabb not declared #405

Closed
dafhi opened this issue Mar 21, 2020 · 0 comments
Closed

Book Two moving_sphere: aabb not declared #405

dafhi opened this issue Mar 21, 2020 · 0 comments
Assignees
@hollasch
Labels
area: book book 2: Next Week
Milestone
v3

Comments

@dafhi
Copy link
Contributor

dafhi commented Mar 21, 2020 •
edited
Loading

Dev.

Listing: [moving_sphere.h] A moving sphere
virt bool bounding_box(tReal t0, tReal t1, aabb& output_box) const;

boom.

(the line isn't needed)
@hollasch hollasch self-assigned this Mar 21, 2020
@hollasch hollasch added this to the v3 milestone Mar 21, 2020
hollasch added a commit that referenced this issue Mar 21, 2020
@hollasch
NextWeek: Remove spurious decl bounding_box()
b3f0bbc 
We had a premature declaration for the virtual function
`moving_sphere::bounding_box()`. Removed it.

Fixes #405
@hollasch hollasch mentioned this issue Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book book 2: Next Week
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@hollasch @dafhi