Skip to content

Fuzzy reflection rays chosen from sphere surface #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

hollasch
Copy link
Collaborator

The prior code randomly chose rays from the volume of the fuzz sphere.

Addresses #1156. This is a draft, as it will need to be manually merged by me after all of the figure renames in the camera update. Let me know if this completely addresses #1156, or if there is more work to be done.

The prior code randomly chose rays from the volume of the fuzz sphere.
@hollasch hollasch added this to the v4.0.0-book1 milestone Jul 12, 2023
@hollasch hollasch requested a review from trevordblack July 12, 2023 19:13
@hollasch hollasch self-assigned this Jul 12, 2023
@trevordblack
Copy link
Collaborator

Oh FFS.
More merge filthiness.

The three uses of random_in_unit_sphere previously were

  1. Called within random_unit_vector
  2. Called within lambertian::scatter
  3. Called within metal::scatter

My previous merge should have killed all instances of (2).
This PR should kill all instances of (3)

Unfortunately there are still a bunch of (2) in the text of the books. It's thankfully no longer in the source, but book text, yes.

As far as this PR goes, the big thing is just replacing the existing image with a new one.

Question. Are you using Limnu for the new image? It looks like you aren't?
We need to either replace all figures with something new, or keep everything as Limnu.

I need to go through and clean up the diffuse chapter ASAP so I'll let you decide what of the above you want to take over

@trevordblack
Copy link
Collaborator

Apologies, but please choose a color other than brown for the ground, it looks like a turd

@hollasch
Copy link
Collaborator Author

Updated.

@hollasch hollasch marked this pull request as ready for review July 17, 2023 18:56
@hollasch hollasch merged commit a309b42 into dev-major Jul 17, 2023
@hollasch hollasch deleted the new-figure-fuzzy-reflection branch July 17, 2023 18:57
hollasch added a commit that referenced this pull request Apr 4, 2024
Small remaining tweaks to book 1.

In general, update source code to match updates from book 1.

material.h: Fix material metal fuzz missed conversions from
random_in_unit_sphere() to random_unit_vector(). See PR #1159.
hollasch added a commit that referenced this pull request Apr 4, 2024
Small remaining tweaks to book 1.

In general, update source code to match updates from book 1.

material.h: Fix material metal fuzz missed conversions from
random_in_unit_sphere() to random_unit_vector(). See PR #1159.

Carried source updates from book 1 forward to the other two books'
source code.
hollasch added a commit that referenced this pull request Apr 5, 2024
Small remaining tweaks to book 1.

In general, update source code to match updates from book 1.

material.h: Fix material metal fuzz missed conversions from
random_in_unit_sphere() to random_unit_vector(). See PR #1159.

Carried source updates from book 1 forward to the other two books'
source code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants