Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code width #247

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Code width #247

merged 4 commits into from
Nov 5, 2019

Conversation

hollasch
Copy link
Collaborator

@hollasch hollasch commented Nov 2, 2019

Maximum line length for both book listings and source files is now 96 characters. This should also make it easier to keep the books and source in sync.

Resolves #219

Code blocks are now flush left, full width of text, overflow visible.

Tested (display + print) on:
  - Windows/Chrome
  - Windows/Brave
  - Windows/Firefox
  - Windows/Edge
  - OSX/Chrome
  - OSX/Brave
  - OSX/Firefox

There are problems on OSX/Safari. Overflow:visible is not honored, but
you can scroll to the right. (Unfortunately, it does the Apple UI thing
where there's no scroll bar to advertise this capability until you
actually scroll.) There are worse problems, though -- images and figures
fail to show at all.
@hollasch hollasch added this to the v3 milestone Nov 2, 2019
@hollasch hollasch requested a review from a team November 2, 2019 23:17
@hollasch hollasch self-assigned this Nov 2, 2019
Copy link
Collaborator

@trevordblack trevordblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hollasch hollasch merged commit cf2bc2c into development Nov 5, 2019
@hollasch hollasch deleted the code-width branch November 5, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants