Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to system2 to be able to capture stderr on error (closes #1257) #1259

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

Enchufa2
Copy link
Member

Minimal changes, fixes #1257. According to rcheology, system2 has been around since 2.12.0, and allows us to capture both stdout and stderr when showOutput=FALSE. A collateral advantage is that now, when an error happens, the output is in the correct order (previously, the error appeared first, then the compilation command).

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@eddelbuettel eddelbuettel changed the title switch to system2 to be able to capture stderr on error switch to system2 to be able to capture stderr on error (closes #1257) Mar 26, 2023
@eddelbuettel eddelbuettel merged commit 54a7416 into master Mar 26, 2023
@eddelbuettel eddelbuettel deleted the fix/source-stderr branch March 26, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourceCpp compile error stderr cannot be caught/suppressed
3 participants