Skip to content

remove command quoting in sourceCpp #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2023
Merged

remove command quoting in sourceCpp #1261

merged 1 commit into from
Mar 27, 2023

Conversation

Enchufa2
Copy link
Member

Of course, system2() already quotes its first argument, I missed that in #1259.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@Enchufa2 Enchufa2 requested a review from eddelbuettel March 27, 2023 09:54
eddelbuettel
eddelbuettel approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eddelbuettel eddelbuettel merged commit 1cefead into master Mar 27, 2023
@eddelbuettel eddelbuettel deleted the fix/windows-quote branch March 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enchufa2 @eddelbuettel