Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set includes in PKG_CPPFLAGS #407

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Conversation

kevinushey
Copy link
Contributor

Fixes the underlying issue in #406. With this, the compiler invocation when building on macOS is (for example):

clang++ -mmacosx-version-min=10.13 -std=gnu++14 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I../inst/include -I'/Users/kevin/Library/R/x86_64/4.2/library/Rcpp/include' -I/usr/local/include   -fPIC  -Wall -g -O2  -c RcppArmadillo.cpp -o RcppArmadillo.o
< ... >

And because -I../inst/include is now coming before -I/usr/local/include, we should now be able to avoid issues where a system installation of Armadillo in /usr/local/include takes precedence over the bundled version.

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice and should not create headaches in other uses / OSs yet protect against the case we saw here.

@eddelbuettel eddelbuettel merged commit adf0b1a into master Feb 11, 2023
@eddelbuettel eddelbuettel deleted the bugfix/macos-armadillo-include branch February 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants